Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed deprecated Polaris Frame usage from AutoTable #645

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

MillanWangGadget
Copy link
Contributor

  • Previously, the toast system for bulk action completion in AutoTable required a Frame wrapper to house the Toast component. This Frame unfortunately had some extra side effects that would cause the table to take on extra height, disrupting existing app user interfaces
  • The frame component has been removed and the toast based bulk action feedback system has been reverted to the banner in modal approach

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to add this in the prev PR to fix that bug so added here

Copy link
Contributor

@alanko0511 alanko0511 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎩
:shipit: 👌

@MillanWangGadget MillanWangGadget merged commit a6e5588 into main Sep 17, 2024
9 checks passed
@MillanWangGadget MillanWangGadget deleted the mill/removeFrameFromAutoTable branch September 17, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants